Skip to content

[Feature] Adding a CLI timeout flag and unit tests - #109

Open
antonio-amjr wants to merge 1 commit into
project-chip:v2.16-cli-developfrom
antonio-amjr:feature/configurable_timeout
Open

[Feature] Adding a CLI timeout flag and unit tests#109
antonio-amjr wants to merge 1 commit into
project-chip:v2.16-cli-developfrom
antonio-amjr:feature/configurable_timeout

Conversation

@antonio-amjr

@antonio-amjr antonio-amjr commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix: project-chip/certification-tool#1038
Related to: project-chip/certification-tool-backend#356

Description

Lets users override the prompt timeout for a single run without editing the project's JSON config.

Changed

  • commands/run_tests.py: new --prompt-timeout SECONDS option; merges {"th_config": {"prompt_timeout_seconds": N}} into the execution config via the existing merge_configs(). Execution-only, not persisted; wins over any value from --config.

Test plan

  • New tests in test_run_tests.py: flag merges into execution config standalone, and takes precedence when combined with --config.
  • New test_utils.py case illustrating a th_config merge.
  • Please run pytest tests/test_run_tests.py tests/test_utils.py before merging.

@antonio-amjr antonio-amjr self-assigned this Aug 21, 2026
@antonio-amjr antonio-amjr added the enhancement New feature or request label Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2febc1f-dead-4644-ac3c-6958752efd04

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@antonio-amjr antonio-amjr changed the title Adding a CLI timeout flag and unit tests [Feature] Adding a CLI timeout flag and unit tests Aug 21, 2026
This was referenced Aug 21, 2026
Open
Open
@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@antonio-amjr antonio-amjr

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@antonio-amjr